Classify webhook subscription modules as configuration experience#8045
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 9, 2026
github-actions
Bot
added
the
no-changelog
isaacroldan
marked this pull request as ready for review
July 10, 2026 11:09
This was referenced Jul 10, 2026
isaacroldan
force-pushed
the
deploy-split/01-cli-kit-order-insensitive-compare
branch
from
July 10, 2026 12:56
55483f3 to
7e9fff4
Compare
isaacroldan
force-pushed
the
deploy-split/02-normalize-experience-type
branch
from
July 10, 2026 12:56
058df67 to
4626a40
Compare
isaacroldan
changed the base branch from
deploy-split/01-cli-kit-order-insensitive-compare
to
graphite-base/8045
July 10, 2026 13:41
isaacroldan
force-pushed
the
graphite-base/8045
branch
from
July 10, 2026 13:42
7e9fff4 to
6a9b8a7
Compare
isaacroldan
force-pushed
the
deploy-split/02-normalize-experience-type
branch
from
July 10, 2026 13:42
4626a40 to
132afc3
Compare
isaacroldan
force-pushed
the
deploy-split/02-normalize-experience-type
branch
from
July 10, 2026 13:42
132afc3 to
5e98c0d
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/common/object.d.ts@@ -38,6 +38,14 @@ export declare function mapValues<T extends object, TResult>(source: T | null |
* @returns True if the objects are equal, false otherwise.
*/
export declare function deepCompare(one: object, two: object): boolean;
+/**
+ * Deeply compares two values and treats arrays as order-insensitive.
+ *
+ * @param one - The first value to be compared.
+ * @param two - The second value to be compared.
+ * @returns True if the normalized values are equal, false otherwise.
+ */
+export declare function deepCompareWithOrderInsensitiveArrays(one: unknown, two: unknown): boolean;
/**
* Return the difference between two nested objects.
*
|
Adds `deepCompareWithOrderInsensitiveArrays` (plus private helpers) to `@shopify/cli-kit/common/object`. Deeply compares two values while treating arrays as unordered, which the deploy/release config breakdown will use to compare webhook subscriptions regardless of ordering. Purely additive: no existing export is modified. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
`normalizeExperience` now receives the spec identifier and maps the webhook subscription spec to the `configuration` experience. This makes the active-app-version deploy/release classification (added later in this stack) treat webhook subscriptions as configuration rather than extensions. No consumer relies on the new classification yet, so behavior is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
isaacroldan
force-pushed
the
deploy-split/02-normalize-experience-type
branch
from
July 10, 2026 14:54
5e98c0d to
439eb86
Compare
alfonso-noriega
approved these changes
Jul 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 10, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The active-app-version classification (#8055) derives each module's create/update/delete status from its
experience. Webhook subscription modules must be treated as configuration, not standalone extensions, or they surface incorrectly in the deploy prompt.WHAT is this pull request doing?
normalizeExperiencenow receives the spec identifier and maps the webhook subscription spec to theconfigurationexperience. Private function; all three call sites updated in-file. No consumer reads the new classification yet, so behavior is unchanged.How to test your changes?
pnpm --filter @shopify/app exec vitest run src/cli/utilities/developer-platform-client/app-management-client.test.ts